From 7b8e961aceb9ae4e5cead0aba09b040f14170c8f Mon Sep 17 00:00:00 2001 From: David Wendt Date: Fri, 7 Apr 2023 17:17:43 -0400 Subject: [PATCH 1/2] Fix unused variable error/warning in page_data.cu --- cpp/src/io/parquet/page_data.cu | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/cpp/src/io/parquet/page_data.cu b/cpp/src/io/parquet/page_data.cu index a68aecaa03c..777c207bfc2 100644 --- a/cpp/src/io/parquet/page_data.cu +++ b/cpp/src/io/parquet/page_data.cu @@ -339,10 +339,11 @@ __device__ void gpuDecodeStream( * additional values. */ template -__device__ cuda::std::pair gpuDecodeDictionaryIndices(volatile page_state_s* s, - volatile page_state_buffers_s* sb, - int target_pos, - int t) +__device__ cuda::std::pair gpuDecodeDictionaryIndices( + volatile page_state_s* s, + [[maybe_unused]] volatile page_state_buffers_s* sb, + int target_pos, + int t) { const uint8_t* end = s->data_end; int dict_bits = s->dict_bits; @@ -524,7 +525,7 @@ __device__ int gpuDecodeRleBooleans(volatile page_state_s* s, */ template __device__ size_type gpuInitStringDescriptors(volatile page_state_s* s, - volatile page_state_buffers_s* sb, + [[maybe_unused]] volatile page_state_buffers_s* sb, int target_pos, int t) { @@ -633,7 +634,7 @@ inline __device__ void gpuOutputString(volatile page_state_s* s, * @param[in] src_pos Source position * @param[in] dst Pointer to row output data */ -inline __device__ void gpuOutputBoolean(volatile page_state_s* s, +inline __device__ void gpuOutputBoolean(volatile page_state_s*, volatile page_state_buffers_s* sb, int src_pos, uint8_t* dst) From e1f00025e493b30fcf428fb0422a66fb830a7ef2 Mon Sep 17 00:00:00 2001 From: David Wendt Date: Fri, 7 Apr 2023 19:28:58 -0400 Subject: [PATCH 2/2] remove unused variable from gpuOutputBoolean --- cpp/src/io/parquet/page_data.cu | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cpp/src/io/parquet/page_data.cu b/cpp/src/io/parquet/page_data.cu index 777c207bfc2..9cf791ef3d9 100644 --- a/cpp/src/io/parquet/page_data.cu +++ b/cpp/src/io/parquet/page_data.cu @@ -629,13 +629,11 @@ inline __device__ void gpuOutputString(volatile page_state_s* s, /** * @brief Output a boolean * - * @param[in,out] s Page state input/output * @param[out] sb Page state buffer output * @param[in] src_pos Source position * @param[in] dst Pointer to row output data */ -inline __device__ void gpuOutputBoolean(volatile page_state_s*, - volatile page_state_buffers_s* sb, +inline __device__ void gpuOutputBoolean(volatile page_state_buffers_s* sb, int src_pos, uint8_t* dst) { @@ -2028,7 +2026,7 @@ __global__ void __launch_bounds__(block_size) gpuDecodePageData( gpuOutputString(s, sb, val_src_pos, dst); } } else if (dtype == BOOLEAN) { - gpuOutputBoolean(s, sb, val_src_pos, static_cast(dst)); + gpuOutputBoolean(sb, val_src_pos, static_cast(dst)); } else if (s->col.converted_type == DECIMAL) { switch (dtype) { case INT32: gpuOutputFast(s, sb, val_src_pos, static_cast(dst)); break;