Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Copy on write implementation #11718
[REVIEW] Copy on write implementation #11718
Changes from all commits
d780606
9baaa08
ec5d461
dc94cde
98d3cae
5bd9dfa
6a941a4
29491f0
98426c3
827f52a
f9e81cf
5a81c2d
c10fb77
f6d1003
212af2e
6e56c86
a1eef3d
6fff02a
744446f
d869dda
11709bc
219ee1b
3c3934c
b86e020
4b423a4
4c7e9cd
aa4620f
c66656b
497f5df
83269ea
ff59856
3d177e0
56e4af5
49994d5
f3bbdfc
de6c9dc
e2b746e
7698958
3bbc9f9
79c5f17
79cc09f
fdc8043
5521016
a902285
6621dc3
385b7de
2d24882
f755758
ff5e3cd
1cebe44
5385e32
0326763
2dab262
160ba75
3ef8ae4
e62c9be
6a63ce1
709dd62
c5e27c3
a0f90d3
82585e1
6028691
6dc355f
5904c8e
0e4ce26
995b66c
ae4b5e0
97584de
804a121
ef21cdb
d916a24
bf449be
dd47e67
a0d4fd4
e36e553
97dd34a
e611c0b
4b2fd7f
27009e6
c8490ff
18146a9
c748a00
1ef8349
58f6245
0642c2e
9603c86
c8c917d
0dcc7cc
c11dfde
f36fa25
8c04594
92fe5d7
e97c851
f01a017
18fda73
e18a9d9
e250f6d
7411805
56ef249
e72eaa3
978f379
87f7641
057967b
2e8a929
ce12519
082202f
b55f039
35a64a5
1abaca0
eba1525
65cb7ac
2e8fc97
b415fa1
1138c1f
2a72d9a
3789255
7ea425c
b0ab29e
ccfd064
7b9b574
93d449e
6dbdf2f
4376702
87cadfe
61260da
499c902
4dd8927
25e1be8
35d513d
d4a9a3f
dd2f61a
3721450
71d7d88
2c95e85
d3bdd86
a43f1f9
8968adb
16aab17
8e2fb6a
5bec54e
937939b
3639564
b423b30
97b4922
1edef2b
bce9781
ce32cf5
2bad64f
1106f95
25511fc
22198a3
80c48f1
0a21c83
9d6c09e
2514142
141ca49
a93709e
12ab4c6
6356765
56eb809
6d5e121
863da0b
da343c5
751294b
c0fe955
2237af2
e2900d8
5cacc1f
4387eac
21f93fb
662756a
e78871c
d02a936
8fe99f4
3f05a63
67660a6
59ac57e
2a2876f
2fcb1f0
201d423
8b589c2
86d580c
f123ad8
3f65c7a
9a16606
71f3ff4
71c4473
863a7ae
c230e94
6e51a5a
ab44c9e
2474f04
f4c9114
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something that happens a lot in workflows? It feels like quite a weak reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this example shows what you want it to.
I think you need to (at least) link to the pandas docs on copy-on-write.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some updates to clarify a bit more. Let me know what you think and how you would want it to improve, if at all.
Unfortunately, copy-on-write is undocumented on pandas public docs :(