Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] isin behavior change while handling inputs of different dtype #7412

Closed
galipremsagar opened this issue Feb 18, 2021 · 0 comments · Fixed by #7479
Closed

[FEA] isin behavior change while handling inputs of different dtype #7412

galipremsagar opened this issue Feb 18, 2021 · 0 comments · Fixed by #7479
Assignees
@galipremsagar
Labels
feature request New feature or request Python Affects Python cuDF API.

Comments

@galipremsagar
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Pandas have updated isin behavior in 1.2.0 where they don't type-cast the provided input values to the type of existing series.

Describe the solution you'd like
Remove the type-casting.

Additional context
pandas-dev/pandas#38781
@galipremsagar galipremsagar added feature request New feature or request Python Affects Python cuDF API. labels Feb 18, 2021
@galipremsagar galipremsagar self-assigned this Feb 18, 2021
@galipremsagar galipremsagar mentioned this issue Mar 1, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #7479 Mar 2, 2021
rapids-bot bot pushed a commit that referenced this issue Mar 2, 2021
@galipremsagar
Add isin examples in Docstring (#7479)
f4f4d87 
Fully resolves: #7412 

Most of the fix to address #7412 were done as part of pandas upgrade in #7375. This PR only includes docstrings update to `isin`.

Authors:
  - GALI PREM SAGAR (@galipremsagar)

Approvers:
  - Keith Kraus (@kkraus14)

URL: #7479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@galipremsagar galipremsagar

Labels
feature request New feature or request Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[REVIEW] Add isin examples in Docstring galipremsagar/cudf
1 participant
@galipremsagar