-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve parameters of cuIO kernels (Avro) #5710
Comments
The changes should include a type that is a non-owning view of a device buffer - something like |
Introducing |
This issue has been labeled |
Keeping the issue open for the existing Avro PR. |
Many cuIO kernels and their callers have a large number of parameters. These functions can the improved by grouping their parameters into meaningful abstractions.
Example:
cudf/cpp/src/io/csv/csv_gpu.h
Lines 150 to 162 in 38921cc
Edit: parameter order is also inconsistent/incorrect - in some places out parameters are places before inputs.
The text was updated successfully, but these errors were encountered: