We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current function needs to be reworked for cudf scatter port. Here is the proposed signature as discussed with @trevorsm7 in slack discussion:
template <typename MapIterator> std::unique_ptr<cudf::column> scatter( strings_column_view const& source, MapIterator scatter_map, strings_column_view const& target, rmm::mr::device_memory_resource* mr = rmm::mr::get_default_resource(), cudaStream_t stream = 0 );
Also, the null mask in the output column will be set by the caller. It will be initialized by copying the target's null mask before returning.
The text was updated successfully, but these errors were encountered:
Looks like scatter will also need a scalar version. Propose this:
scatter
template<typename MapIterator> std::unique_ptr<column> scatter( string_scalar const& source, MapIterator scatter_iter, size_type scatter_rows, string_column_view const& target, rmm::mr::device_memory_resource* mr = rmm::mr::get_default_resource(), cudaStream_t stream = 0);
Sorry, something went wrong.
Perhaps instead of two separate APIs for scattering a column/scalar, just make the source an iterator?
source
davidwendt
Successfully merging a pull request may close this issue.
Current function needs to be reworked for cudf scatter port. Here is the proposed signature as discussed with @trevorsm7 in slack discussion:
Also, the null mask in the output column will be set by the caller. It will be initialized by copying the target's null mask before returning.
The text was updated successfully, but these errors were encountered: