Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Add strings support to cudf::gather #3415

Closed
jrhemstad opened this issue Nov 19, 2019 · 0 comments · Fixed by #3303
Closed

[FEA] Add strings support to cudf::gather #3415

jrhemstad opened this issue Nov 19, 2019 · 0 comments · Fixed by #3303
Assignees
Labels
feature request New feature or request strings strings issues (C++ and Python)

Comments

@jrhemstad
Copy link
Contributor

Is your feature request related to a problem? Please describe.
cudf::gather should support gathering columns of strings.

Describe the solution you'd like
Now that the internal strings column gather function is complete, it should be plugged into the cudf::gather public API to add support for gathering strings columns.

This should be added via SFINAE of the column_gatherer function object to add a code path for string_view that calls the internal string column gather.

Note that the bitmask from the string column gather is uninitialized, and it should be updated in the gather_bitmask_kernel that same as all of the rest of the columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request strings strings issues (C++ and Python)
Projects
None yet
2 participants