Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Port copying.hpp to cudf::column types #2934

Closed
harrism opened this issue Oct 3, 2019 · 2 comments
Closed

[FEA] Port copying.hpp to cudf::column types #2934

harrism opened this issue Oct 3, 2019 · 2 comments
Assignees
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS

Comments

@harrism
Copy link
Member

harrism commented Oct 3, 2019

Is your feature request related to a problem? Please describe.

Now that #2207 is merged we need to start porting functionality to use it. This issue covers functionality defined in cudf/copying.hpp.

It may make sense to split this into multiple PRs since there is a lot of functionality covered by copying.hpp.

Describe the solution you'd like

Update the API functions definitions in cudf/binaryop.hpp and their implementations to use the new cudf::column and associated classes.

Note that until string columns and other wrapper types are supported, operations will only be able to be implemented for numerical columns. Initially the "legacy" APIs should be kept in place but moved to the cudf/legacy folder and if necessary a legacy namespace.

@harrism harrism added feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. tech debt labels Oct 3, 2019
@harrism harrism added the Spark Functionality that helps Spark RAPIDS label Oct 4, 2019
@harrism
Copy link
Member Author

harrism commented Nov 4, 2019

@rgsl888prabhu is there anything left from copying.hpp (other than gather/scatter) to port? If not, let's close this.

@rgsl888prabhu
Copy link
Contributor

Nothing apart from scatter and gather, so we can close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

No branches or pull requests

3 participants