Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Migrate Unit tests to use AST Tree #17400

Open
lamarrr opened this issue Nov 21, 2024 · 0 comments
Open

[FEA] Migrate Unit tests to use AST Tree #17400

lamarrr opened this issue Nov 21, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@lamarrr
Copy link
Contributor

lamarrr commented Nov 21, 2024

Is your feature request related to a problem? Please describe.
We presently manually construct and manage the lifetimes of AST tree subexpressions, the ast subexpressions bind references to each other, we added an AST tree type (ast_tree) in #17156 to help with this and also automatically cleanup the objects.
Our tests manually construct the AST subexpression trees which is error-prone and has lead to bugs (i.e. #17292).

Describe the solution you'd like
We'd like to convert our unit tests and benchmarks to use the new ast_tree type, and also recommend it to our users instead of manually constructing the tree.

@lamarrr lamarrr added the feature request New feature or request label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant