Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OrcReader benchmark failure #10158

Closed
karthikeyann opened this issue Jan 28, 2022 · 9 comments
Closed

[BUG] OrcReader benchmark failure #10158

karthikeyann opened this issue Jan 28, 2022 · 9 comments
Labels
bug Something isn't working cuIO cuIO issue tests Unit testing for project

Comments

@karthikeyann
Copy link
Contributor

Describe the bug
ORC_READER_BENCH crashes with

 terminate called after throwing an instance of 'cudf::logic_error'
   what():  cuDF failure at: /home/karthikeyan/3cudf/cpp/benchmarks/io/orc/orc_reader.cpp:145: Benchmark did not read the entire table

Steps/Code to reproduce bug
./benchmarks/ORC_READER_BENCH --benchmark_filter=OrcRead/row_selection/0/4/1/3/0

or
Run all OrcRead/row_selection benchmarks.
time ./benchmarks/ORC_READER_BENCH --benchmark_filter=row_selection

Additional context
Discovered while working on #10109

@karthikeyann karthikeyann added bug Something isn't working Needs Triage Need team to review and classify tests Unit testing for project labels Jan 28, 2022
@GregoryKimball
Copy link
Contributor

Looks like a duplicate of #9961

@github-actions
Copy link

github-actions bot commented Mar 3, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@karthikeyann
Copy link
Contributor Author

Still relevant. The issue is not fixed. The benchmark arg is disabled in #10194
#9963 (comment)

// row_selection::ROW_GROUPS disabled until we add an API to read metadata from a parquet file and
// determine num row groups. https://github.com/rapidsai/cudf/pull/9963#issuecomment-1004832863

@GregoryKimball GregoryKimball added cuIO cuIO issue and removed Needs Triage Need team to review and classify labels Jun 26, 2022
@github-actions
Copy link

This issue has been labeled inactive-90d due to no recent activity in the past 90 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed.

@GregoryKimball
Copy link
Contributor

Closing in favor of #11675

@GregoryKimball
Copy link
Contributor

@karthikeyann Did I make a mistake here? It seems like we should probably re-open this.

@vyasr
Copy link
Contributor

vyasr commented Jun 29, 2023

I'll reopen for now so that we don't lose track. @karthikeyann feel free to close again if the closing was correct, but I agree that it seems unrelated to the linked issue.

@vyasr vyasr reopened this Jun 29, 2023
@vyasr
Copy link
Contributor

vyasr commented May 14, 2024

Looking back, I think this was indeed closed for the wrong reasons, but it can be closed. This issue is no longer relevant after #11611 and #11543

@vyasr vyasr closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cuIO cuIO issue tests Unit testing for project
Projects
None yet
Development

No branches or pull requests

3 participants