Skip to content

Commit

Permalink
Fix some unused variable warnings in libcudf (#9326)
Browse files Browse the repository at this point in the history
Some unused variable warnings are appearing in 11.4 builds from recent PR merges.

Authors:
  - David Wendt (https://github.com/davidwendt)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)
  - Nghia Truong (https://github.com/ttnghia)

URL: #9326
  • Loading branch information
davidwendt authored Sep 29, 2021
1 parent bef2c35 commit fdb9e3b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
13 changes: 5 additions & 8 deletions cpp/src/groupby/sort/group_tdigest.cu
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,8 @@ __global__ void generate_cluster_limits_kernel(int delta_,
nearest_w_index = last_inserted_index + 1;
auto [r, i, adjusted] = cumulative_weight(nearest_w_index);
adjusted_next_limit = max(next_limit, adjusted);
(void)r;
(void)i;
}
cluster_wl[group_num_clusters[group_index]] = adjusted_next_limit;
last_inserted_index = nearest_w_index;
Expand Down Expand Up @@ -469,6 +471,7 @@ std::unique_ptr<column> compute_tdigests(int delta,
group_cumulative_weight] __device__(size_type value_index) -> size_type {
auto [group_index, relative_value_index, cumulative_weight] =
group_cumulative_weight(value_index);
(void)relative_value_index;

// compute start of cluster weight limits for this group
double const* weight_limits = group_cluster_wl + group_cluster_offsets[group_index];
Expand Down Expand Up @@ -601,15 +604,9 @@ struct typed_group_tdigest {

template <
typename T,
typename... Args,
typename std::enable_if_t<!cudf::is_numeric<T>() && !cudf::is_fixed_point<T>()>* = nullptr>
std::unique_ptr<column> operator()(column_view const& col,
cudf::device_span<size_type const> group_offsets,
cudf::device_span<size_type const> group_labels,
cudf::device_span<size_type const> group_valid_counts,
size_type num_groups,
int delta,
rmm::cuda_stream_view stream,
rmm::mr::device_memory_resource* mr)
std::unique_ptr<column> operator()(Args&&...)
{
CUDF_FAIL("Non-numeric type in group_tdigest");
}
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/lists/drop_list_duplicates.cu
Original file line number Diff line number Diff line change
Expand Up @@ -376,10 +376,10 @@ struct column_row_comparator_dispatch {
}

template <class Type, std::enable_if_t<!cudf::is_equality_comparable<Type, Type>()>* = nullptr>
bool operator()(size_type i, size_type j) const
bool operator()(size_type, size_type) const
{
CUDF_FAIL(
"`column_row_comparator_dispatch` cannot operate on types that are not equally comparable.");
"column_row_comparator_dispatch cannot operate on types that are not equally comparable.");
}
};

Expand Down

0 comments on commit fdb9e3b

Please sign in to comment.