Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object preserving problems on {"op": "remove"} #35

Closed
narcoticfresh opened this issue Aug 25, 2016 · 0 comments
Closed

Object preserving problems on {"op": "remove"} #35

narcoticfresh opened this issue Aug 25, 2016 · 0 comments
Labels

Comments

@narcoticfresh
Copy link
Contributor

So well.. After #28, #32, #33, here comes the next one in the series to make it all "object safe" ;-)
Sadly our devs only now thought to use the {"op": "remove"}, so this only comes out now ;-/ If I look at the remaining ops, this really should be the last one ;-)

When {"op": "remove"} is used on a hierarchy that leads or contains to empty objects, they are falsely converted from {} to []..

There are even tests that assert this wrong behavior..

Details will be visible in the PR..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants