Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AUR] Tray icon fails to load #580

Open
jkdel opened this issue Nov 18, 2023 · 6 comments
Open

[AUR] Tray icon fails to load #580

jkdel opened this issue Nov 18, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@jkdel
Copy link

jkdel commented Nov 18, 2023

Bug Report

App Version: 2.0.2

Platform: Linux

Installation Method: AUR

Bug Description:
Fallback icon in systray. Clicking the icon does not open Sleek when the app is reduced to systray.

Steps to Reproduce:

  1. Open Sleek → fallback icon in systray
  2. Activate setting "minimize to taskbar"
  3. Close the window
  4. Clicking the systray icon does nothing

Expected Behavior:

  • Expected Sleek icon in systray
  • Expected clicking the systray icon to open Sleek

Additional Information: Console log

main.ts: Error: Failed to load image from path '/usr/lib/sleek/app.asar/assets/icons/tray/tray.png'
    at de (/usr/lib/sleek/app.asar/dist/main/main.js:8:260030)
    at /usr/lib/sleek/app.asar/dist/main/main.js:8:270632

The correct path on my system would be '/usr/lib/sleek/assets/icons/tray/tray.png'

@jkdel jkdel added the bug Something isn't working label Nov 18, 2023
@ransome1 ransome1 moved this to Backlog in sleek 2.x Nov 18, 2023
@ransome1 ransome1 moved this from Backlog to 2.0.3 in sleek 2.x Nov 22, 2023
@ransome1 ransome1 moved this from 2.0.3 to In Progress in sleek 2.x Nov 23, 2023
@ransome1
Copy link
Owner

The correct path on my system would be '/usr/lib/sleek/assets/icons/tray/tray.png'

After installing sleek through AUR, that particular png is located in exactly this location? It would really surprise me, because I think this means sleek had not been packaged during the installation process. Can you check with your terminal or file browser if you can reach that file like this?

Can you check real quick if this also happens if you use the AppImage release? I need to make sure, this only happens with AUR only.

Also, how did you install sleek? With yay?

@jkdel
Copy link
Author

jkdel commented Nov 23, 2023

Hi,

thanks for the nice app and looking into the issue. I should have provided these details in the first place I guess (hadn't tested the AppImage though):

  • After installing sleek-bin (2.0.2-1) via yay I get the error main.ts: Error: Failed to load image from path '/usr/lib/sleek/app.asar/assets/icons/tray/tray.png' and can find the file at /usr/lib/sleek/assets/icons/tray/tray.png
  • After installing sleek (2.0.1-1) via yay I get the error main.ts: Error: Failed to load image from path '/usr/lib/sleek.asar/assets/icons/tray/tray.png'. I can find the asar archive at said location but still only have a placeholder icon in the tray and after unpacking the asar archive, there was no icon to be found.
  • With the AppImage (2.0.3-rc2) there is no issue (main.ts: Tray created and clicking the tray icon opens the window)

The AUR packages are the currently available versions there. I've just noticed that the AppImage is more up to date.

The issue occurs on Arch Linux with Gnome and the AppIndicator and KStatusNotifierItem Support shell extension. However, since it works with the AppImage and the path error messages are explicit, I assume this is likely not the issue.

@ransome1
Copy link
Owner

I think it has something to do with the way the releases in AUR are being built. Thus this bug report is fully valid.

@ransome1 ransome1 changed the title Tray icon fails to load [AUR] Tray icon fails to load Nov 28, 2023
@ransome1 ransome1 moved this from In Progress to 2.0.3 in sleek 2.x Nov 28, 2023
@warmwaffles
Copy link

I can try a rebuild of the package

@warmwaffles
Copy link

warmwaffles commented Nov 28, 2023

I updated the AUR to v2.0.2 from v2.0.1

Indeed, the tray icon is not present.

Error creating tray: Error: Failed to load image from path '/usr/lib/sleek.asar/assets/icons/tray/tray.png'
    at de (/usr/lib/sleek.asar/dist/main/main.js:8:260030)
    at e.exports.<anonymous> (/usr/lib/sleek.asar/dist/main/main.js:8:263592)
    at EventEmitter.n (/usr/lib/sleek.asar/dist/main/main.js:2:16042)
    at EventEmitter.emit (node:events:525:35)
    at set store [as store] (/usr/lib/sleek.asar/dist/main/main.js:2:15333)
    at e.exports.set (/usr/lib/sleek.asar/dist/main/main.js:2:14061)
    at IpcMainImpl.Oe (/usr/lib/sleek.asar/dist/main/main.js:8:265091)
    at IpcMainImpl.emit (node:events:513:28)
    at WebContents.<anonymous> (node:electron/js2c/browser_init:2:88759)
    at WebContents.emit (node:events:513:28)

@ransome1
Copy link
Owner

I havn't yet found the time to look into it. Somehow we need to include the missing icons into the .asar file during the build process. I won't be able to fix this before 2.0.4 I'm afraid. But it's in the backlog.

@ransome1 ransome1 moved this from 2.0.3 to Backlog in sleek 2.x Nov 29, 2023
@ransome1 ransome1 moved this from Backlog to Bugs in sleek 2.x Dec 14, 2023
Repository owner deleted a comment from github-actions bot Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Bugs
Development

No branches or pull requests

3 participants