Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle inverted subclass queries #72

Open
cbizon opened this issue Apr 4, 2023 · 0 comments
Open

handle inverted subclass queries #72

cbizon opened this issue Apr 4, 2023 · 0 comments

Comments

@cbizon
Copy link
Contributor

cbizon commented Apr 4, 2023

Right now, if you have a query like this:
(a)-related_to->(b)-related_to->(c)
One valid response is:
(a)-subclass_of->(b)<-subclass_of-(c)

This is bad because b can be something like MONDO:0000001 or some other general node and you're basically saying that just about any A and C can be connected this way. Lots of (bad) answers.

There are a few approaches:

  1. add a size filter on the degree of (b)
  2. disallow subclass of edges in the body of the query.
  3. Make use of the biolink hierarchy: there is a related_at_entity_level, so we could use that at query time instead of related_to. The problem with this is that it will require sub-predicates in the query which was one of the things that was causing slow/bad queries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant