A lot of optimization (234% faster!) #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the core logic of parsing/decoding just once to the compile script This significantly reduces the size of the generated code file (2MB -> 1.3MB for BRFLD), decreasing the time it takes to compile.
duncathan
approved these changes
Aug 29, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 71.24% 72.27% +1.02%
==========================================
Files 54 55 +1
Lines 2817 2950 +133
==========================================
+ Hits 2007 2132 +125
- Misses 810 818 +8
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE:
starter preset: 10.6s
april fools: 13.2s
AFTER:
starter preset: 3.169s
april fools: 5.46s
Door Lock rando has a very slow O(n^3) path filtering which can be fixed in so many ways :P