You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Lets add a file in src/configs/repo_config.env that can contain such configurations. Side note: Personally, I'd probably add it as a root-level file (eg. .repo_config.env), but I remember that you wanted to keep the repo root as tidy as possible.
This file could then be consumed by .github/workflows/ci.yml and .../nightly.yml as well as here and (for now) just contain:
# the fork of boringssl that should be used for BoGo tests
BORINGSSL_REPO=https://github.com/randombit/boringssl.git
# the branch in our fork of boringssl that should be used for BoGo tests
BORINGSSL_BRANCH=rene/runner-20241016
# Limbo test suite
LIMBO_TEST_SUITL_URL=...
# Jitterentropy library source archive URL
JITTERENTROPY_SOURCE_ARCHIVE_URL=...
We might have more such configuration that is worth to centralize like that. In any case: I'd do this adaption in an independent PR (likely after 3.6.0).
Some configurations are duplicated multiple times in the repository: I had said we should centralize some of those.
Suggestion:
Lets add a file in
src/configs/repo_config.env
that can contain such configurations. Side note: Personally, I'd probably add it as a root-level file (eg..repo_config.env
), but I remember that you wanted to keep the repo root as tidy as possible.This file could then be consumed by
.github/workflows/ci.yml
and.../nightly.yml
as well as here and (for now) just contain:We might have more such configuration that is worth to centralize like that. In any case: I'd do this adaption in an independent PR (likely after 3.6.0).
What are your thoughts on this?
Originally posted by @reneme in #4389 (comment)
The text was updated successfully, but these errors were encountered: