Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Central Repository Config File #4390

Closed
reneme opened this issue Oct 17, 2024 · 0 comments · Fixed by #4422
Closed

Create a Central Repository Config File #4390

reneme opened this issue Oct 17, 2024 · 0 comments · Fixed by #4422
Assignees
Milestone

Comments

@reneme
Copy link
Collaborator

reneme commented Oct 17, 2024

Some configurations are duplicated multiple times in the repository: I had said we should centralize some of those.

Suggestion:

Lets add a file in src/configs/repo_config.env that can contain such configurations. Side note: Personally, I'd probably add it as a root-level file (eg. .repo_config.env), but I remember that you wanted to keep the repo root as tidy as possible.

This file could then be consumed by .github/workflows/ci.yml and .../nightly.yml as well as here and (for now) just contain:

# the fork of boringssl that should be used for BoGo tests
BORINGSSL_REPO=https://github.com/randombit/boringssl.git

# the branch in our fork of boringssl that should be used for BoGo tests
BORINGSSL_BRANCH=rene/runner-20241016

# Limbo test suite
LIMBO_TEST_SUITL_URL=...

# Jitterentropy library source archive URL
JITTERENTROPY_SOURCE_ARCHIVE_URL=...

We might have more such configuration that is worth to centralize like that. In any case: I'd do this adaption in an independent PR (likely after 3.6.0).

What are your thoughts on this?

Originally posted by @reneme in #4389 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant