FIX: ./configure.py --with-build-dir= #4245
Open
+22
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reneme
commented
Jul 22, 2024
Comment on lines
-3558
to
+3557
| source_paths = SourcePaths(os.path.dirname(argv[0])) | ||
| source_paths = SourcePaths(os.path.dirname(os.path.realpath(__file__))) |
There was a problem hiding this comment.
This caused the explained issue. argv[0] may be a valid relative path (seen from $($pwd)), but it is not valid when --with-build-dir= drops the generated build files somewhere else and paths in there are relative to whatever argv[0] was.
reneme
force-pushed
the
fix/configure_paths
branch
from
280fe9c
to
6052dac
Compare
reneme
force-pushed
the
fix/configure_paths
branch
from
6052dac
to
471925b
Compare
|
Rebased to master (to resolve a conflict with #4336). |
|
Turns out that listing all the object files with their absolute path can overwhelm Windows' upper limit on command lengths. I'll have a look into that as soon as I can. |
This allows using the cmake-ish flow of `mkdir build && cd build && ../configure.py` resulting in all build artefacts being dropped in build or build/build respectively.
reneme
force-pushed
the
fix/configure_paths
branch
from
471925b
to
0fc18fc
Compare
|
Rebased after #4350 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Dependencies
Description
Running
./configure.py --with-build-dir=mybuilddidn't work properly, because it produced a Makefile/ninja.build with paths relative to the base-directory of theconfigure.pyinvocation (i.e.argv[0]). It did work when invoking it like that:$(pwd)/configure.py --with-build-dir=mybuild.The idea behind this patch is to always produce absolute paths in the Makefile/ninja.build. As a side effect, this allows us to remove a mingw workaround. Also, I cleaned up the ninja.build of
botan_bogo_shimandbotan_ct_selftestthat both dropped their intermediate object files in the top-level build directory.Closes #4232
Closes #4342