Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_lb_target_group logic error on long names #92

Closed
bellis-ai opened this issue Sep 1, 2023 · 1 comment
Closed

aws_lb_target_group logic error on long names #92

bellis-ai opened this issue Sep 1, 2023 · 1 comment

Comments

@bellis-ai
Copy link

name = "${local.controlplane_name}-${var.cp_port}"

This is problematic.

According to line 3 (

controlplane_name = "${substr(var.name, 0, 23)}-rke2-cp"
), the maximum length of controlplane_name is 31 characters.

If we combine this with the -6443 that's stuck on the end, that's 36 characters.

target groups can only have up to 32 characters. This breaks if given a long name. Please handle this scenario.

@adamacosta
Copy link
Collaborator

Fixed by #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants