Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Support new T3 instances and EBS NVMe block devices #2461

Closed
niranjan94 opened this issue Sep 2, 2018 · 6 comments
Closed

Support new T3 instances and EBS NVMe block devices #2461

niranjan94 opened this issue Sep 2, 2018 · 6 comments

Comments

@niranjan94
Copy link

RancherOS Version: v1.4.0

Where are you running RancherOS? AWS


Currently, In C5, C5d, i3.metal, M5, M5d, R5, R5d, T3, and z1d instances, EBS volumes are exposed as NVMe block devices. The device names are /dev/nvme0n1, /dev/nvme1n1, and so on.

Ref: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/nvme-ebs-volumes.html

But the current Official Rancher AMI image does not recognize this correctly when deploying on one of these instance, Say T3. As it still looks for and uses the previous block names (/dev/xvda and so on) and the rancher.resize_device is also set as /dev/xvda whereas it should be set as /dev/nvme0n1

@Jason-ZW
Copy link

Jason-ZW commented Sep 3, 2018

similar #2381

@niusmallnan
Copy link
Contributor

@Jason-ZW No, this is another issue.

@niranjan94 We have supported this feature. It only worked on m5 and c5. Now AWS supports more instance types, so we need to add them.
https://github.com/rancher/os/blob/master/config/cloudinit/datasource/metadata/ec2/metadata.go#L146-L149
https://github.com/rancher/os/blob/master/cmd/cloudinitexecute/cloudinitexecute.go#L197-L199

@kingsd041
Copy link
Contributor

Fixed in ros v1.4.2-rc1

# ros -v
version v1.4.2-rc1 from os image rancher/os:v1.4.2-rc1
# ros c export
rancher:
resize_device: /dev/nvme0n1
# fdisk -l
Device         Boot Start      End  Sectors Size Id Type
/dev/nvme0n1p1 *    16065 62914526 62898462  30G 83 Linux

@kingsd041
Copy link
Contributor

Sorry, I only tested the T3 instance and omitted other types of instances.

@kingsd041
Copy link
Contributor

I tested the C5, C5d, i3.metal, M5, M5d, R5, R5d, T3, and z1d instances, the block device changed to "/dev/nvme0n1" and supported resize_device

@niusmallnan
Copy link
Contributor

backported to v1.4.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants