-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generic hook to customize component flags #290
Comments
Will there be a PR for this very soon? I ask because I need to alter flags for testing with ipv6 #284 . I already build |
I have applied this patch and was able to start an ipv6-only cluster #284 . |
Verified I could add
Didn't test kube-proxy since it appears k3s does not have INFO logs that show the flags used to start kube-proxy. |
Currently k3s sets a series of flags on the kube-apiserver, controller-manager, scheduler, kube-proxy, and kubelet. The flags are essentially hard coded and non-user customizable.
I'd like a generic hook to be added so that on
k3s server
ork3s agent
one can add any k8s component flag and it will be set on the component. This can be accomplished by doing a format like--component-flag=value
. For example--kubelet-allow-privileged=false
. The code would just look for all arguments starting with kubelet, apiserver, controller-manager, scheduler, or proxy (or maybe have kube-* in the beginning too) and them just strip the prefix and pass to the right component.Since we don't want to do fancy arg parsing we would only accept the single arg syntax and not the double arg syntax. What I mean by that is that
--kubelet-insecure-port=1234
would be accepted but not--kubelet-insecure-port 1234
. Maybe we could accept the second form, but I'm afraid we might mess up parsing (or maybe it's actually really easy?).Related #282
The text was updated successfully, but these errors were encountered: