Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove common invalid properties when updating kube resources #9371

Closed
richard-cox opened this issue Jul 19, 2023 · 6 comments · Fixed by #10037
Closed

Remove common invalid properties when updating kube resources #9371

richard-cox opened this issue Jul 19, 2023 · 6 comments · Fixed by #10037
Assignees
Labels
kind/bug QA/manual-test Indicates issue requires manually testing size/3 Size Estimate 3
Milestone

Comments

@richard-cox
Copy link
Member

richard-cox commented Jul 19, 2023

Epic #9016

  • This is the first step to tackle the epic
  • We should identify the common kube properties that are provided in existing resources that aren't needed when we update them
    • At the moment these are seen as console warnings (dev) or debug (prod) when updating them
    • As a starting, and possibly ending point, see shell/utils/create-yaml.js NEVER_ADD
  • Once we know the common properties we should remove them when resources are saved
    • there's already some kind of concept of doing this for cleaning yaml (which uses NEVER_ADD)
    • we probably need to wire it in to the steve model save
@richard-cox
Copy link
Member Author

Note - most of the common properties will be handled by the backend - see rancher/rancher#41772

@ghost ghost self-assigned this Aug 8, 2023
@nwmac nwmac unassigned ghost Sep 1, 2023
@nwmac nwmac modified the milestones: v2.8.0, v2.8.next1 Sep 1, 2023
@cnotv
Copy link
Contributor

cnotv commented Sep 13, 2023

We need an unit test for this one, so we know what the utility is supposed to do...

@Shavindra
Copy link
Contributor

Awaiting more clarification rancher/rancher#41772 (comment)

@richard-cox
Copy link
Member Author

I added a comment that side, but in summary they should be removed

@cnotv
Copy link
Contributor

cnotv commented Dec 15, 2023

@richard-cox we should stop mixing up configuration and utilities, so it would be nice to take this out and avoid confusion next time (or in a separated issue).

@github-actions github-actions bot reopened this Jan 8, 2024
@nwmac nwmac added the QA/manual-test Indicates issue requires manually testing label Jan 30, 2024
@izaac izaac self-assigned this Jul 22, 2024
@izaac
Copy link
Contributor

izaac commented Jul 22, 2024

The release target fix was Rancher 2.7.7 where the fix validation execution was done.

I did the same repro steps to validate there wasn't a regression on Rancher v2.9.0-rc2
Steps detailed here.

@izaac izaac closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/manual-test Indicates issue requires manually testing size/3 Size Estimate 3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants