Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3 snapshots do not show in the UI #3693

Closed
davidnuzik opened this issue Aug 5, 2021 · 12 comments
Closed

s3 snapshots do not show in the UI #3693

davidnuzik opened this issue Aug 5, 2021 · 12 comments

Comments

@davidnuzik
Copy link

Rancher Server Setup

  • Rancher version: v2.6-head 246fbd5fa 8/5/21 (single-node docker)
  • Installation option (Docker install/Helm Chart): Docker 19.03

Downstream cluster: rke2 provisioned by rancher, 3 etcd, 2 cp, 3 worker
Downstream k8s version: v1.21.3-rc3+rke2r2

Describe the bug

  1. Create a cluster. Submit valid s3 information.
  2. Take a snapshot. This appears to be successful.
2021/08/05 22:35:57 [INFO] rkecluster fleet-default/dave-rke2-s3test: refreshing etcd create state
2021/08/05 22:35:58 [INFO] rkecluster fleet-default/dave-rke2-s3test: starting etcd snapshot
2021/08/05 22:35:58 [INFO] rkecluster fleet-default/dave-rke2-s3test: waiting for etcd snapshot
2021/08/05 22:35:58 [INFO] rkecluster fleet-default/dave-rke2-s3test: waiting for etcd snapshot
2021/08/05 22:35:58 [INFO] rkecluster fleet-default/dave-rke2-s3test: waiting for etcd snapshot
2021/08/05 22:35:58 [INFO] rkecluster fleet-default/dave-rke2-s3test: waiting for etcd snapshot
2021/08/05 22:35:58 [INFO] rkecluster fleet-default/dave-rke2-s3test: waiting for etcd snapshot
2021/08/05 22:36:04 [INFO] rkecluster fleet-default/dave-rke2-s3test: waiting for etcd snapshot
2021/08/05 22:36:04 [INFO] rkecluster fleet-default/dave-rke2-s3test: refreshing etcd create state
2021/08/05 22:36:04 [INFO] rkecluster fleet-default/dave-rke2-s3test: provisioning bootstrap node(s) dave-rke2-s3test-e-59bc958d8-bvkrg
2021/08/05 22:36:04 [INFO] rkecluster fleet-default/dave-rke2-s3test: provisioning bootstrap node(s) dave-rke2-s3test-e-59bc958d8-bvkrg
2021/08/05 22:36:04 [INFO] rkecluster fleet-default/dave-rke2-s3test: provisioning bootstrap node(s) dave-rke2-s3test-e-59bc958d8-bvkrg: waiting for plan to be applied
2021/08/05 22:36:04 [INFO] rkecluster fleet-default/dave-rke2-s3test: provisioning bootstrap node(s) dave-rke2-s3test-e-59bc958d8-bvkrg: waiting for plan to be applied
2021/08/05 22:36:22 [INFO] rkecluster fleet-default/dave-rke2-s3test: provisioning bootstrap node(s) dave-rke2-s3test-e-59bc958d8-bvkrg: waiting for plan to be applied
  1. Inspect the s3 bucket - everything is there it looks like the snapshot was successful and I can retake snapshots and they will work and upload to my bucket.
    image

  2. Inspect the snapshots tab - none of the snapshots show.
    image

Note: Refreshing the UI does not fix the issue. Cleaning browser cache and launching the UI again also does not fix.

Result
The UI does not show any of the (apparently) successfully-taken s3 snapshots.

Expected Result

The UI should show the s3 snapshots, just like it does for local snapshots.

Additional Info
Blocks testing/closure of rancher/rancher#32391

@davidnuzik davidnuzik self-assigned this Aug 5, 2021
@davidnuzik davidnuzik transferred this issue from rancher/dashboard Aug 5, 2021
@thedadams
Copy link

Rancher looks at the configmap rke2-etcd-snapshots in the downstream RKE2 cluster to get the information for the snapshots. In this case, the configmap exists, but it is empty.

> kubectl -n kube-system get configmap rke2-etcd-snapshots -o yaml
apiVersion: v1
kind: ConfigMap
metadata:
  creationTimestamp: "2021-08-05T22:30:30Z"
  name: rke2-etcd-snapshots
  namespace: kube-system
  resourceVersion: "378"
  uid: 118aca17-9b4d-428b-af38-32043e65e8ac

@davidnuzik davidnuzik changed the title s3 backups do not show in the UI s3 snapshots do not show in the UI Aug 5, 2021
@deniseschannon deniseschannon transferred this issue from rancher/rancher Aug 6, 2021
@deniseschannon deniseschannon added this to the v2.6 milestone Aug 6, 2021
@richard-cox
Copy link
Member

@thedadams Is that the correct location to look at, if so is this a backend issue?

@thedadams
Copy link

@richard-cox I believe it is an RKE2 issue. It seems RKE2 is responsible for populating the configmap.

@Jono-SUSE-Rancher
Copy link

This is being worked on by the RKE2 team via rancher/rke2#1551, once they have a fix in place I will move this back over to test.

@richard-cox
Copy link
Member

I've tagged this as waiting for backend (we don't have a waiting for rke column/label)

@davidnuzik
Copy link
Author

Yes, I am working with the RKE2 team via rancher/rke2#1551 as Jono mentioned. Once there is a fix/solution there then I'll post an update here.

@davidnuzik
Copy link
Author

Will be fixed by rancher/rke2#1551 probably today or tomorrow depending on how things go. We know the nature of the issue now after troubleshooting/debugging.

@briandowns
Copy link

The linked issue above is now in "to test" with the resolved PR's merged and backported.

@davidnuzik
Copy link
Author

Need rke2 rc first; will put this on pause until have that and 2.6 KDM points to the new RC.

@davidnuzik
Copy link
Author

davidnuzik commented Aug 11, 2021

rancher/rancher#34088 is changing how s3 works so waiting on that now.

@davidnuzik
Copy link
Author

davidnuzik commented Aug 20, 2021

So this was working and it's not again, but the nature of the issue seems to be different. The ConfigMap is indeed populated now but the snapshots don't show in the UI. Bit difficult to reproduce though -- I think this may be caused (but do not know why) by a failed snapshot restoration - local snapshots do not work now when attempt to restore. I think if this happens and one cluster gets stuck in Error state all other clusters won't list out their snapshots now even though they were successfully taken and show in the ConfigMap.

Not quite sure if I should open a new bug or just re-use this one - the cause seems different now, but I technically can't close out this issue because snapshots don't show in the UI. hmm

@davidnuzik
Copy link
Author

This appears to be working now. Restore does not work but that is a separate issue.

My checks PASSED

Reproduction Steps:

Not required.

Validation Environment:

Rancher version: v2.6-head 0935a90 pulled at 8/24/21 11:09 am Pacific
Rancher cluster type: single-node docker
Docker version: 20.10

Downstream cluster type: rke2
Downstream K8s version: v1.21.3+rke2r2

Validation steps:

  1. Create an RKE2 cluster, specify valid s3 config during cluster creation (this creates an s3-compatible cloud credential for us).
  2. Once the cluster is ready, take a snapshot. The snapshot is listed in the UI now (the ConfigMap is also populated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants