Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup and introduce visual testing tools and CI #9057

Open
cnotv opened this issue Jun 6, 2023 · 5 comments · May be fixed by #13035
Open

Setup and introduce visual testing tools and CI #9057

cnotv opened this issue Jun 6, 2023 · 5 comments · May be fixed by #13035
Assignees
@cnotv
Labels
area/ci CI and automation related, e.g. GitHub Actions area/storybook area/test Test (e2e and unit) kind/tech-debt Technical debt QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Milestone
v2.12.0

Comments

@cnotv
Copy link
Member

cnotv commented Jun 6, 2023 •
edited
Loading

Description

Avoid the need for manual tests as in the current state, almost 400 issues have been created.

Define tools, setup and configure CI for visual testing. The goal is to track visual changes on components which are added in Storybook as style guide.
This tracks down to typography and spacing, as well as basic components, aspects which should be consistent and not possible to test in other ways than visually.

More about Storybook visual testing: https://storybook.js.org/tutorials/visual-testing-handbook/

Example Issues

Other cases which may not be required in the style guide have to be considered in somehow:

Finally we may think about an automation to match the provided design, e.g.:
@cnotv cnotv added area/test Test (e2e and unit) kind/tech-debt Technical debt area/ci CI and automation related, e.g. GitHub Actions area/storybook QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Jun 6, 2023
@cnotv cnotv added this to the v2.7.next3 milestone Jun 6, 2023
@gaktive gaktive mentioned this issue Jun 8, 2023
Closed
@gaktive
Copy link
Member

gaktive commented Jun 8, 2023

We can do a quick spike about the framework for Q3 but realistically, this is a Q4 project.

@cnotv
Copy link
Member Author

cnotv commented Jun 8, 2023

We have to define it too, because it's not written in the issue.

@gaktive gaktive modified the milestones: v2.7.next3, v2.8.next4 Jul 17, 2023
@nwmac nwmac modified the milestones: v2.8.0, v2.8.next1 Aug 15, 2023
@cnotv cnotv mentioned this issue Oct 4, 2023
Open
@nwmac nwmac modified the milestones: v2.8.next1, v2.8.next2 Oct 23, 2023
@nwmac nwmac modified the milestones: v2.8.next2, v2.10.0 Feb 27, 2024
@cnotv cnotv mentioned this issue Mar 25, 2024
Closed
@nwmac nwmac modified the milestones: v2.10.0, v2.11.0 Jul 4, 2024
@cnotv cnotv self-assigned this Jan 8, 2025
@gaktive
Copy link
Member

gaktive commented Jan 8, 2025

@a-arias has started to look at visual testing with @rancher-max so do sync up and see if there's any double effort to watch out for.

@cnotv
Copy link
Member Author

cnotv commented Jan 8, 2025 •
edited
Loading

I guess we missed track of my work since November 😅
This is what I've been working on so far: https://github.com/cnotv/dashboard/tree/refs/heads/feature/10469-visual-regressions

I also have a full report of the research of several pages where I'm tracking all the options and issues.

PS: This ticket is almost ready for PR, so it may be worth to get an update here of new requirements, since I see nothing written.

This was referenced Jan 9, 2025
Open
Open
@cnotv
Copy link
Member Author

cnotv commented Jan 16, 2025 •
edited
Loading

Waiting for team decisions for this issue and to fix the issue with yarn lock in #13103 or #13085 to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cnotv cnotv

Labels
area/ci CI and automation related, e.g. GitHub Actions area/storybook area/test Test (e2e and unit) kind/tech-debt Technical debt QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Milestone
v2.12.0
Development

Successfully merging a pull request may close this issue.

Setup and introduce visual testing tools and CI cnotv/dashboard
3 participants
@nwmac @cnotv @gaktive