Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Downstream v2prov clusters do not accurately reflect configured rewrites and mirrors #12524

Open
Josh-Diamond opened this issue Nov 6, 2024 · 4 comments · Fixed by #12527
Assignees
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this regression status/release-blocker
Milestone

Comments

@Josh-Diamond
Copy link

Rancher Server Setup

  • Rancher version: v2.10-f95d1dc120a4b4c602fcb1485b36134fc0f4a2bc-head
  • Installation option (Docker install/Helm Chart): Helm

Information about the Cluster

  • Kubernetes version: v1.31.2+rke2r1, v1.31.2+k3s1
  • Cluster Type (Local/Downstream): Downstream Node driver

User Information

  • What is the role of the user logged in? Admin

Describe the bug
When provisioning a downstream v2Prov Node driver cluster w/ mirrors and rewrites configured, the cluster comes up active and successfully provisions, but /etc/rancher/agent/registries.yaml, as well as Rancher UI Edit Config > Registries, does not reflect the expected configurations, set during the initial cluster provisioning

To Reproduce

  1. Fresh install of Rancher v2.10-head
  2. Provision a downstream RKE2 cluster, v1.31.2+rke2r1, with cluster scoped registry enabled and the following configurations set:
    • Registry hostname: docker.io
    • Mirror endpoints: https://registry.example.com
    • Rewrite Config -> Rewrite pattern: ^rancher/(.*)
    • Rewrite Config -> Rewrite replacement: mirrorproject/rancher-images/$1
  3. Verified - cluster successfully provisions
  4. Reproduced

Result
/etc/rancher/agent/registries.yaml does NOT accurately reflect configured rewrites and mirrors

{"configs":{},"mirrors":null}

Expected Result
/etc/rancher/agent/registries.yaml accurately reflect configured rewrites and mirrors

Additional context
Only affects v2.10 branch

@Josh-Diamond Josh-Diamond added this to the v2.10.0 milestone Nov 6, 2024
@Josh-Diamond Josh-Diamond self-assigned this Nov 6, 2024
@Josh-Diamond
Copy link
Author

Josh-Diamond commented Nov 6, 2024

Upon further troubleshooting, UI is not passing these fields to API call when creating the provisioning cluster object

screenshot_2024-11-06_at_11 07 00_am

@Josh-Diamond Josh-Diamond transferred this issue from rancher/rancher Nov 6, 2024
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Nov 6, 2024
@gaktive
Copy link
Member

gaktive commented Nov 6, 2024

This worked in 2.9.x

@rak-phillip
Copy link
Member

Updating milestone to v2.11, will create a v2.10 backport issue.

@rak-phillip
Copy link
Member

/backport v2.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this regression status/release-blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants