Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and Update vue.config.js #12504

Open
6 tasks
rak-phillip opened this issue Nov 5, 2024 · 0 comments
Open
6 tasks

Review and Update vue.config.js #12504

rak-phillip opened this issue Nov 5, 2024 · 0 comments
Labels
QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this

Comments

@rak-phillip
Copy link
Member

Recent updates to Dashboard include significant changes that may have impacted vue.config.js:

  • Migration from Nuxt to Vue.js
  • Upgrade from Vue 2 to Vue 3
  • Upgrade from Webpack 4 to Webpack 5

With these changes in place, it's a good time to review shell/vue.config.js to ensure that the configuration is still relevant, not overly complicated, and functioning as expected.

Proposed solution

  • Verify that all configurations in vue.config.js are still necessary
  • Review and address the TODO items in shell/vue.config.js
  • Add explanations for any logic in vue.config.js that may not be immediately clear

Acceptance criteria

  • vue.config.js is updated and optimized
  • All TODO items are addressed and resolved
  • vue.config.js includes clear explanations for any non-obvious logic

Additional info

After encountering #12244, I thought it would be best to confirm that there aren't any other unexpected surprises with regards to how Dashboard is built and bundled.

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

No branches or pull requests

1 participant