Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capella LightClientUpdate type is wrong #197

Closed
aeryz opened this issue May 23, 2023 · 1 comment · Fixed by #346
Closed

Capella LightClientUpdate type is wrong #197

aeryz opened this issue May 23, 2023 · 1 comment · Fixed by #346

Comments

@aeryz
Copy link

aeryz commented May 23, 2023

LightClientUpdate of capella is a re-export from altair.

But in the spec, although the definition of the LightClientUpdate seem to be unchanged at the top level, the definition of LightClientHeader is changed.
See: altair, capella.

So I am suggesting to add LightClientHeader type to capella and change LightClientUpdate type. I can tackle the PR if I am not mistaken.

@ralexstokes
Copy link
Owner

hey! thanks for raising this issue

this part of this repo has not been updated since some things in the spec have changed and I'd love to have a PR updating them :)

yeah it looks like there is this new defn of a LightClientHeader and that ripples to update the LightClientUpdate type in capella

if you make a pass on it, im happy to review the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants