Support custom krew index

[tamalsaha]

Thanks for this bot. We are looking to use this bot with our hosted custom plugin index.
ref: https://krew.sigs.k8s.io/docs/developer-guide/custom-indexes/

Is that possible? If not, could that be supported?

[rajatjindal]

hey @tamalsaha , thanks for reaching out. I follow/admire your work on a lot of kubernetes related projects, so it means a lot to hear from you.

the custom index support should be already supported (you can override the default krew-index org/repo using env variables). could you please try that once?

also seems like the url you provided is not for the custom krew-index right?

in the meantime, i would give this a try too, and revert back.

[rajatjindal]

ok, i looked at the code, its on server side where u can use env variable to override the krew-index org/repo. I will explore making change to be able to override them from client side (github-action), and report back.

[tamalsaha]

Thanks for the kind words, @rajatjindal ! This work also looks very impressive.

We have decided to extend our existing release automation process to also update the krew manifest, instead of using this action. I did use your idea to use a krew.yaml template. Sorry taking up your time.

[rajatjindal]

Sure, thanks.

I will keep this ticket open to add the support incase anyone else needs that in future

Thanks again

[ArtemTrofimushkin]

hello @rajatjindal !
is there any updates on this issue?

[rajatjindal]

Hi @ArtemTrofimushkin

I haven't had chance to look at this yet. I will try to spend some time on this next week. (or may be you can submit as a PR?)

thanks

[ArtemTrofimushkin]

Thanks!
I will submit PR in a few days!

[ankishagarwal]

@ArtemTrofimushkin Were you able to work on this ?

[Gearheads]

Hello, I think I might have a possible solution to this issue, if that would be ok for me to submit?

[rajatjindal]

sure, I would be happy to review the changes. If you want to outline your plan on how you want to implement that, that would be great as well.

[Gearheads]

awesome, thank you so much. I have created the PR. Please let me know if there is anything missing, or needs to be updated.

[Gearheads]

Hi @rajatjindal, apologies to bother you, I was wondering if you had a chance to review the changes within the PR?

[rajatjindal]

Hi @Gearheads

Apologies for the delay. I was catching up on a backlog. I will find time to test/merge this PR this week. thanks again.

[Gearheads]

Hi @rajatjindal, no worries. I completely understand. Thank you for taking the time to review, and test. Please let me know if anything that needs to be changed. 😄