Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl-C does not abort interactive session #627

Closed
2 tasks done
fatso83 opened this issue Feb 10, 2020 · 4 comments · Fixed by xuwei-k/scala-protobuf-docs#103 or igorovic/test-actions#8
Closed
2 tasks done

Comments

@fatso83
Copy link

fatso83 commented Feb 10, 2020

  • node version: 12.7.0
  • npm version: 6.10
  • npm-check-updates version: 3.2.0

I have tried several times to test the interactive option for this tool, and very often I want to abort the process and so I press Ctrl-C to send a signal to quit the ongoing operation. This is not respected by the tool, which for some reason has chosen to interpret this as a YES to the current question. This is a highly unconventional choice 😄

I would like to signal listener to interpret Ctrl-C as a signal to do process.exit(1) or at least give the user a prompt to quit.

@raineorshine
Copy link
Owner

I tend to agree. npm-check-updates uses the package prompts which does seem to support detection of Ctrl + C.

@fatso83
Copy link
Author

fatso83 commented Feb 12, 2020

There are various ways of achieving this, though one might need to resort to hacks like this for some cases: terkelg/prompts#252 (comment) (actively avoids printing a "Y").

@Tchoupinax
Copy link
Contributor

Hello,
I met this bug and i encourage its fix :)

Thank you for your work.

@raineorshine
Copy link
Owner

Fixed and published in v11.1.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment