Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: l1 priority fee crash on zora, base #933

Merged
merged 3 commits into from
Sep 12, 2023

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Sep 12, 2023

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

https://rainbowhaus.slack.com/archives/C04M9BUPQP6/p1694488278657739

keepPreviousData was off for these chains so it was causing the crash

Screen recordings / screenshots

https://www.loom.com/share/0dcec726c1e448368abf6cc5f8960314

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@estebanmino estebanmino marked this pull request as ready for review September 12, 2023 14:35
@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-3e16b5164ba84e64df66fdcf23d3612a8a98b021.zip

@estebanmino estebanmino merged commit 7b5bd04 into master Sep 12, 2023
14 checks passed
@estebanmino estebanmino deleted the @esteban/fix-l1-priority-fee branch September 12, 2023 17:57
@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-7b5bd0480b10891b873ad514f151d60f76ad6157.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants