fix: BX-1341 #1387
fix: BX-1341 #1387
Conversation
|
Here's the packed extension for this build: |
| @@ -165,7 +164,7 @@ export const WatchAsset = ({ | |||
| }); | |||
| } | |||
|
|
|||
| approveRequest(null); | |||
| approveRequest(true); | |||
There was a problem hiding this comment.
looking at ApproveAppRequest.tsx seems like approveRequest and rejectRequest send the same msg to background but if the payload is null it considers a reject, shouldn't we solve it in that component?
I think AddEthereumChain.tsx also calls approveRequest(null)
There was a problem hiding this comment.
yeah that's exactly the case, so we're sending true instead
maybe your AddEthereumChain is outdated https://github.com/rainbow-me/browser-extension/blob/master/src/entries/popup/pages/messages/AddEthereumChain/index.tsx#L79
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
fixing ticket and returning true when request is accepted
#1382
Fixes #1382
Screen recordings / screenshots
What to test