feat: Wipe wallet group #1331
feat: Wipe wallet group #1331
Conversation
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
BrodyHughes
changed the title
|
Here's the packed extension for this build: |
There was a problem hiding this comment.
UI looks great! Noticed an issue where the Wallet Group would re-appear in the Wallets & Keys menu initially after completing the flow. The group would shift from "Backed Up" to the "Not backed up" state. Then when completing the flow again, it would be fully removed
|
Here's the packed extension for this build: |
cannot repro. |
BrodyHughes
requested review from
brunobar79,
DanielSinclair,
greg-schrammel,
estebanmino and
derHowie
|
@BrodyHughes Found another issue where dapps connections persist after we remove a seed phrase, leading to these keychain errors. This might be true for "hide wallet" and "remove wallet" features too. I think we'll need to implement a watcher or logic to automatically disconnect dapps in these scenarios |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
| } | ||
|
|
||
| export default function WarningInfo({ | ||
| iconAndCopyList, |
There was a problem hiding this comment.
maybe this don't have to be a prop either, seems like a very specific component no need to abstract it, or change the name and abstract to use in the other similar screens?
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
| @@ -22,25 +18,18 @@ import * as wallet from '../../../handlers/wallet'; | |||
| const t = (s: string) => | |||
| i18n.t(s, { scope: 'settings.privacy_and_security.wallets_and_keys' }); | |||
|
|
|||
| async function handleWipeWallet() { | |||
There was a problem hiding this comment.
could maybe inline this now bc it's way smaller now with your refactor. idk what your preference is.
There was a problem hiding this comment.
I like creating functions outside the component when possible, so it won't be recreated on every rerender, but it's not a huge performance gain here I'd go with whatever you think is more readable, up to you
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
Co-authored-by: Daniel Sinclair <[email protected]> Co-authored-by: gregs <[email protected]>
Fixes BX-1254
Figma link: https://www.figma.com/file/hzfwKOddfRmeVO4KUsG9wM/branch/bQjlkhAqO2w3nk7NJF5EKS/Rainbow-BX?type=design&node-id=15871-3647&mode=design&t=XOaSEV6pKSICFPvc-0
What changed (plus any additional context for devs):
Screen recordings / screenshots
POW:
Screen.Recording.2024-02-02.at.3.20.13.PM.mov