Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose maintainers #144

Closed
stefan6419846 opened this issue Feb 21, 2023 · 5 comments · Fixed by #154
Closed

Expose maintainers #144

stefan6419846 opened this issue Feb 21, 2023 · 5 comments · Fixed by #154

Comments

@stefan6419846
Copy link

Some packages do not have the author field set, but the maintainer one (example: https://github.com/opencv/opencv-python/blob/b776e5ce9f164600a1bd05178a058272122bf02a/setup.py#L272). Exposing the maintainer as well would allow users to work with the maintainer value if the author value would be empty otherwise.

@raimon49
Copy link
Owner

Good suggestion.

For example, would you prefer OpenCV Team(maintainer) as the output result, or simply OpenCV Team ?

@stefan6419846
Copy link
Author

This depends on the output format in my opinion. For me, a new key maintainer returned by piplicenses.get_packages would be sufficient as I am rendering the results myself and can decide on how I want to display maintainers. I am not sure about the actual rendered output though, as I am not actually using it.

@raimon49
Copy link
Owner

Then, it might be a good idea to output a new column like --with-maintainers.

Think of something and prepare a release candidate version.

@raimon49 raimon49 mentioned this issue Apr 2, 2023
@raimon49
Copy link
Owner

raimon49 commented Apr 2, 2023

@stefan6419846 A release is planned to resolve this suggestion.

The next release candidate version has been uploaded to PyPI.
https://pypi.org/project/pip-licenses/4.2.0rc1/

Install it in your environment and make sure it is working as expected.

pip install pip-licenses==4.2.0rc1

There is some time before the official release. Feedback is welcome.

@stefan6419846
Copy link
Author

I just did a quick test and could everything seems to work as expected. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants