using the middleware with rails 8 breaks rails routes generation

[francescob]

I've upgraded my application to rails 8 and now the line
config.middleware.use(JsRoutes::Middleware)

in development.rb causes the rails routes to be empty. Removing the line the application works as normal

[le0pard]

try

Rails.application.routes_reloader.try(:execute_unless_loaded)

before

config.middleware.use(JsRoutes::Middleware)

[francescob]

thanks for the super quick reply, unfortunately that line leads to the app failing to boot with the following error:

/home/francesco/.asdf/installs/ruby/3.3.4/lib64/ruby/gems/3.3.0/gems/railties-8.0.0/lib/rails/engine.rb:602:in unshift: can't modify frozen Array: [] (FrozenError)

[le0pard]

ok, looks like need to find best way to fix this (looks like similar to heartcombo/devise#5705 )

[le0pard]

Maybe adding application.reload_routes_unless_loaded in beginning of

js-routes/lib/js_routes/instance.rb

Lines 25 to 27 in 9bedb7f

	def generate
	# Ensure routes are loaded. If they're not, load them.
	application = T.unsafe(self.application)

may fix problem. Are you able to test @francescob (create fork and modify it) ?

so it will be

     def generate
      # Ensure routes are loaded. If they're not, load them.
      application = T.unsafe(self.application)
      if named_routes.empty?
        if application.respond_to?(:reload_routes_unless_loaded, true)
          application.reload_routes_unless_loaded
        elsif application.respond_to?(:reload_routes!, true)
          application.reload_routes!
        end
      end
      ...

[francescob]

yes, that fixed it. I'm creating a pull request

[bogdan]

Fixed in 2.3.0