Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fastlane to Semaphore #22

Open
wants to merge 108 commits into
base: master
Choose a base branch
from
Open

Conversation

stringparser
Copy link
Contributor

@stringparser stringparser commented Apr 6, 2021

@stringparser stringparser force-pushed the feature/21-adds-fastlane branch from 99143a6 to 5d1c8b1 Compare April 6, 2021 15:21
@stringparser stringparser changed the title feature(#24): change machine type Add fastlane to Semphore Apr 6, 2021
@stringparser stringparser changed the title Add fastlane to Semphore Add fastlane to Semaphore Apr 6, 2021
@stringparser stringparser force-pushed the feature/21-adds-fastlane branch from 250af56 to 4c42838 Compare April 6, 2021 15:35
@stringparser stringparser force-pushed the feature/21-adds-fastlane branch from 4c42838 to 6b67c75 Compare April 6, 2021 15:35
@stringparser stringparser self-assigned this Apr 6, 2021
@stringparser stringparser added this to the v1 milestone Apr 6, 2021
@stringparser stringparser linked an issue Apr 6, 2021 that may be closed by this pull request
3 tasks
@stringparser stringparser marked this pull request as draft April 9, 2021 15:59
@stringparser
Copy link
Contributor Author

For this one would love some help. Would be able to help me next week @bonflintstone ?

My plan is to get fastlane working locally with the certificates and then setup the pipeline but I haven't done this in a while so can't remember the quirks at the moment.

@stringparser
Copy link
Contributor Author

stringparser commented Apr 13, 2021

Checking if you can help here

https://media.giphy.com/media/LhLxJ8zIQA6TS/giphy.gif

Let me know if don't have time though so I can plan a bit for it ;)

https://media.giphy.com/media/GovaRwvorav5K/giphy.gif

Copy link
Member

@bonflintstone bonflintstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Needs ssh to clone apple-credentials repo for fastlane match
- chmod 600 ~/.ssh/apple_certificates_deploy_rsa
- ssh-add ~/.ssh/apple_certificates_deploy_rsa

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why no jetify here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS?

@stringparser
Copy link
Contributor Author

@bonflintstone have got to a wall with the CD so I was thinking I should ask for help. Would be best if you can 🙏

So far I can tell this is the current state for each platform for the CI

Android:

  • gradle builds
  • we need to setup the services.json file see fastlane docs which leads to the play store. Have asked Salim since I don't have access right now

iOS:

Locally I can build iOS with fastlane but seems there is something missing.

Keep in mind we can't have any private information here (ios team id, etc.) because this repo will be made public at some point for adding QR code providers to a list (see readme). That is, we'll open the repo for people to integrate with the app at some point.

@stringparser
Copy link
Contributor Author

@bonflintstone What I'm saying with this last paragraph is that we should add any private infor like the (service.json file for android) environment variables in Semaphore

@stringparser stringparser marked this pull request as ready for review June 10, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fastlane to Sempahore
2 participants