Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core extension monkey-patch conflicts #2387

Closed
zapnap opened this issue Aug 18, 2015 · 2 comments
Closed

Core extension monkey-patch conflicts #2387

zapnap opened this issue Aug 18, 2015 · 2 comments

Comments

@zapnap
Copy link
Contributor

zapnap commented Aug 18, 2015

I'm having some issues with Hash#symbolize in particular, because it's conflicting with extensions in another gem I'm using. That other gem is actually patching the class via Refinements, so it's not really doing anything wrong per se (I'm not a huge fan of refinements personally but at least it's compartmentalized). Any chance we could migrate the core extensions to more functional-style helpers? Would be happy to send a PR if that is deemed acceptable...

https://github.com/sferik/rails_admin/blob/master/lib/rails_admin/support/core_extensions.rb
@zapnap zapnap mentioned this issue Aug 18, 2015
Merged
@zapnap
Copy link
Contributor Author

zapnap commented Aug 18, 2015

Added a PR for this. Thanks for considering it!

@zapnap
Copy link
Contributor Author

zapnap commented Aug 19, 2015

Fixed - see #2388

@zapnap zapnap closed this as completed Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zapnap