Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other custom text editors? (markdown via MarkItUp) #1235

Closed
Tuckie opened this issue Jul 3, 2012 · 3 comments
Closed

Other custom text editors? (markdown via MarkItUp) #1235

Tuckie opened this issue Jul 3, 2012 · 3 comments
Assignees

Comments

@Tuckie
Copy link

Tuckie commented Jul 3, 2012

After seeing the codemirror pull: #1164 I was wondering how difficult it would be to add other client side editors into rails admin?

I'm looking at incorporating markdown support into my application, but a little extra assistance via MarkItUp is probably going to be needed.

https://www.ruby-toolbox.com/gems/markitup_rails3
http://markitup.jaysalvat.com/home/

Looking at code changes that was required, it doesn't appear to be very modular. Is there a better way to cleanly integrate different editors (maybe just as a markdown field type)?

@mshibuya
Copy link
Member

mshibuya commented Jul 9, 2012

I agree with the notion that it isn't modular. We should clean it up.

Separating each of richtext supports into different classes, like in meta code

class RailsAdmin::Config::Fields::Types::CKEditor < Text; end
class RailsAdmin::Config::Fields::Types::CodeMirror < Text; end
...

will improve modularity, although problem will be still left in JS logics in ra.widgets.coffee.

Is there anyone who is up to this task? :)

@ghost ghost assigned mshibuya Aug 8, 2012
@neersighted
Copy link

👍

@mshibuya
Copy link
Member

Modularization is already accomplished by 967efc6.
Please submit PR is you're still interested in markdown support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants