Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files in packs directory must have unique base file names #2096

Closed
levinmr opened this issue May 20, 2019 · 2 comments
Closed

Files in packs directory must have unique base file names #2096

levinmr opened this issue May 20, 2019 · 2 comments

Comments

@levinmr
Copy link

levinmr commented May 20, 2019

Webpacker does not correctly create the manifest.json content if multiple files in the packs directory have the same basename (i.e. application.*)

Steps to reproduce:

  • Create a new rails app with webpacker
  • Add /app/javascript/packs/application.js
  • Add /app/javascript/packs/application.css
  • rails assets:precompile
  • manifest.json includes compiled application.js only, application.css is omitted.
  • Change application.css to any other file basename, repeat above steps, and manifest is created correctly.

This is minor and easy to add to documentation, but caused quite the headache as it took awhile to determine exactly what was happening here.

@jakeNiemiec
Copy link
Member

Dupe of #2088, it points to https://github.com/rails/webpacker/blob/master/package/environments/base.js#L65 as the source of the problem.

@rossta
Copy link
Member

rossta commented Jan 13, 2021

Fixed by #2476

@rossta rossta closed this as completed Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants