-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rails 6.0.0.beta1: Webpacker builds test app assets #1908
Comments
@javan Do you have any idea, what's going on here? |
It has something to do with installing the npm package from github directly. If I point --- a/package.json
+++ b/package.json
@@ -5,7 +5,7 @@
"@rails/actioncable": "^6.0.0-alpha",
"@rails/activestorage": "^6.0.0-alpha",
"@rails/ujs": "^6.0.0-alpha",
- "@rails/webpacker": "https://github.com/rails/webpacker",
+ "@rails/webpacker": "4.0.0-rc.5", |
IMO, we should revert 895d2cf. |
Makes sense, perhaps we can use next tag to install the pre version instead (if one)? |
Please try the new release. Thanks, Javan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
rails new demo
RAILS_ENV=production rails assets:precompile
The webpacker will compile all the test assets, for example:
Expected behavior
The test assets such as
/public/assets/@rails/webpacker/lib/install/examples/stimulus/
should not be compiled in production mode.Actual behavior
There are some assets compiled including:
@rails/webpacker/lib/install/javascript/packs/...
@rails/webpacker/test/test_app/app/javascript/packs/...
@rails/webpacker/lib/install/examples/stimulus/...
. Note: this example project does not have a dependency ofstimulus
.System configuration
Rails version:
Rails 6.0.0.beta1
Ruby version:
ruby 2.6.0p0 (2018-12-25 revision 66547) [x86_64-darwin18]
The text was updated successfully, but these errors were encountered: