Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Webpacker "support" hot module reloading? #154

Closed
justin808 opened this issue Mar 3, 2017 · 3 comments
Closed

Should Webpacker "support" hot module reloading? #154

justin808 opened this issue Mar 3, 2017 · 3 comments

Comments

@justin808
Copy link
Contributor

For a long discussion on this topic, see: Hot Module Reloading #332.

Maybe this HMR will be stable eventually.

We support this feature for React on Rails via examples, but not as a core part of the gem. By this, I mean that we do not add the extra complexity of HMR. In retrospect, this was a great decision.

@gauravtiwari
Copy link
Member

@justin808 I don't think webpacker provides this out-of-the-box? It does provide webpack-dev-server support, but not with --hot option. Perhaps, something to clear out in the readme.

@ytbryan
Copy link
Contributor

ytbryan commented Mar 20, 2017

Am I missing something here?

Because this should be already supported because of webpack-dev-server?

Must it be explicitly supported for React? For Vue, it comes out of the box whenever i switch on webpack-dev-server.

@justin808
Copy link
Contributor Author

justin808 commented Mar 20, 2017

We can close this. Webpack dev server is hot reloading and the ability to have the asset helpers use a different port is money.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants