-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest.json doesn't include relative_url_root. #1357
Comments
@gauravtiwari @jpickwell Is this right? I'm also 'mounting' my app under a subdirectory, but it only works if I remove the code merged here. I believe the |
This worked for the app I was working on at the time, but a lot has changed. That app is now on a dedicated subdomain, so I'm no longer using |
@sspread the removal of relative path broke all urls inside scss files in my app when it runs in a subdirectory. Generated URLs don't include the app subdirectory in |
@sspread - What was the underlying problem that caused this to be removed? We deploy quite a few apps in sub directories and currently, webpack doesn't seem to know anything about the relative url root, so assets within css or scss files, like images used as background images for DOM elements, do not properly resolve because they are missing the relative url root. |
For production sandbox deployment I have the app "mounted" under a subdirectory; e.g.,
example.com/subdir
.Currently, webpacker doesn't include the
RAILS_RELATIVE_URL_ROOT
in themanifest.json
, even if it's set.The text was updated successfully, but these errors were encountered: