Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrations still appear in webpacker.yml #1148

Closed
iainbeeston opened this issue Dec 26, 2017 · 2 comments
Closed

Integrations still appear in webpacker.yml #1148

iainbeeston opened this issue Dec 26, 2017 · 2 comments

Comments

@iainbeeston
Copy link

In #1103 integrations were moved out of the default webpacker install, and now have to be added manually. However, the default webpacker.yml still includes extensions for .jsx, .coffee, .vue and .erb. Should these be removed from the default webpacker.yml file, and be added by the appropriate installer rake task?
@iainbeeston
Copy link
Author

Just to be clear, the webpacker.yml file I'm looking at is https://github.com/rails/webpacker/blob/7738e6b2a25b5e35874cf5290a6e680ec10794b0/lib/install/config/webpacker.yml

@gauravtiwari
Copy link
Member

Good spot 👍 Yes they should be moved to installer.

@gauravtiwari gauravtiwari mentioned this issue Jan 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iainbeeston @gauravtiwari