-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if there are multiple manifest files #560
Warn if there are multiple manifest files #560
Conversation
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I'm good with this warning. Looks like you need a rebase. Can we also add the name of the manifest file that is being selected to the warning? |
Is this meant to be backwards compatible or a breaking change? In that I’m getting bug reports about argument errors, for |
Supposed to be backwards compat. Can you tag me on some of your issues
please? Do any of them have a reproduction “example app”?
On Fri, May 24, 2019 at 5:27 PM Jordon Bedwell ***@***.***> wrote:
Is this meant to be backwards compatible or a breaking change? In that I’m
getting bug reports about argument errors, for jekyll-assets manifest,
but it seems that this pull defaults the second argument?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#560?email_source=notifications&email_token=AAAOSYH6Z3PLEZ43U5ZNROLPXBTV3A5CNFSM4FHHDXQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWGV6SA#issuecomment-495804232>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAOSYC6XCMISXBOEVH26SDPXBTV3ANCNFSM4FHHDXQA>
.
--
Richard Schneeman
https://www.schneems.com
|
When I’m at my laptop in the morning I’ll tag you in the issue I got and put up an example app! |
fixes parts of #559
When, somehow, there are two potential manifest files, raise a warning before picking the first one.