Polymorphic URL should default to HTTPS if force_ssl = true

[johnnyshields]

No description provided.

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

[eileencodes]

Hey @johnnyshields looks like this broke a whole bunch of tests that don't have access to the Rails constant. Can you take a look at those?

[eileencodes]

Actually, we can't access the Rails configuration inside ActionPack which is why the tests are failing. Railties isn't (and shouldn't be) a dependency of AP, so this patch isn't going to work as is.

[johnnyshields]

One option is if defined?(Rails) && Rails.config.force_ssl but that seems like quite a hackish solution. Is there any other way I can access the config?

[matthewd]

Without looking closely, this sounds like the wrong place to do it: I'd expect this to be right next to something that's defaulting the host, and to only apply in that case. Maybe finding that place will hold a clue for getting the value, as well?

[johnnyshields]

@matthewd I think you're right, it should go at least near somewhere in the model-specific url helper and ideally in the part with the host. I'll take a closer look later.