Use a custom deprecator instead of ActiveSupport::Deprecation directly #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@byroot Is there anything I can do to get this merged? Right now active resource it's not compatible with rails 7.2 if you have any deprecation warnings. |
adrian-gomez
force-pushed
the
update_deprecator
branch
from
5874cc0
to
01f9912
Compare
adrian-gomez
force-pushed
the
update_deprecator
branch
from
01f9912
to
1063d6a
Compare
|
Is this going to be released soon? |
|
App deprecators were added in Rails 7.1. This PR breaks Rails 6.1 and 7.0 support. |
|
@jeremy do you have a repro or even just a error+backtrace? Because this OR checks for the Rails version, and 6.1 and 7.0 are tested on CI. |
|
Hum, I see: #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address some errors we are getting while trying to update to rails 7.2