Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates JSON API Adapter to generate RC4 schema #925

Merged
merged 3 commits into from
May 27, 2015

Conversation

benedikt
Copy link
Contributor

As JSON API RC4 was published yesterday (with the final release date pushed back to 2015-05-28), this pull request updates the JsonApi adapter to match the new changes to the schema.

Relevant changes to the spec:

  • Attributes (other than id and type) are now nested under the attributes key.
  • Relationships are now nested under the relationships key instead of the links key
  • The linkage key for relationships is now called data

This resulted in these changes to the gem:

  • Tests are adjusted to reflect the new schema
  • The adapter now renders the new schema
  • The methods releated to links are renamed to avoid confusion
  • fragment_cache now does a deep_merge instead of just a simple merge

Feedback welcome! I'm happy to adjust things as necessary. :)

@joaomdmoura
Copy link
Member

Hey @benedikt, tks for submit this!
I'll review the PR and get back to you 😄

@jamesbrooks
Copy link

👍

@kurko
Copy link
Member

kurko commented May 27, 2015

Awesome!

kurko added a commit that referenced this pull request May 27, 2015
Updates JSON API Adapter to generate RC4 schema
@kurko kurko merged commit 16f7512 into rails-api:master May 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants