Fix explicit serializer for associations #821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to apply this patch in order to get the explicit association serializers feature to work as expected with the
has_many
association. Looked like a probable typo (the feature PR #696 renamed :options to :association_options, and forgot to update this one to match).I've updated the
test_includes_linked_comments
test with the proper expected result (the old test was not invoking the explicithas_many
association serializer functionality at all).