Document ams model #1873
Closed
Document ams model #1873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove duplicated check in `read_attribute_for_serialization`
|
@aldreth, thanks for your PR! By analyzing the annotation information on this pull request, we identified @bf4, @ggordon and @mateomurphy to be potential reviewers |
Cache now returns attributes with symbolized keys
|
One big problem/bug right now with ams::model is that the attributes hash doesn't sync with the attr_accessor values. This causes all sorts of problems. It's essentially and unresolved implementation detail between ActiveModel::Model and ActiveModel::Serialization. |
| @@ -250,8 +250,9 @@ def test_a_serializer_rendered_by_two_adapter_returns_differently_fetch_attribut | |||
| # Assert attributes are serialized correctly | |||
| serializable_alert = serializable(alert, serializer: AlertSerializer, adapter: :attributes) | |||
| attributes_serialization = serializable_alert.as_json | |||
| assert_equal expected_fetch_attributes, alert.attributes | |||
| assert_equal alert.attributes, attributes_serialization | |||
| alert_attributes_symbolized = alert.attributes.symbolize_keys | |||
There was a problem hiding this comment.
I can see the value of adding a test for symbolizing, but it looks like you're replacing the existing one?
|
@bf4 Thanks for your comments. I'm off on holiday for 2 weeks now. I'll pick this up when I come back. |
|
@aldreth would still love some help here |
|
Mobile.... Sorry, missed 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #1283
I think this resolves 2 of your checkboxes - #1272 (comment) & #1272 (comment)
I don’t know what to do to resolve #1272 (comment) & don’t know what to put in the changelog.