Prefer object.cache_key when available. #1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this is broken, but now it's easier to see what it should be. |
bf4
changed the title
|
This code was hard to extract and could use a good review. @kevintyll Does this work for you? Also see #1644 |
| @@ -161,13 +193,20 @@ def test_fragment_cache_with_inheritance | |||
| refute_includes(base.keys, :special_attribute) | |||
| end | |||
|
|
|||
| def test_uses_adapter_in_cache_key | |||
There was a problem hiding this comment.
This test is not proving that the adapter is in the cache key.
|
👍 |
bf4
changed the title
bf4
force-pushed
the
kevintyll-master
branch
3 times, most recently
from
9cb0841 to
e7c3ebc
Compare
This will prevent objects PORO objects that don't have updated_at defined, from throwing an error. Not as big a deal now that PORO objects can inherit ActiveModelSerializers::Model, but still necessary if it's not inherited for whatever reason. Add the Adapter type to the cache key. This prevents incorrect results when the same object is serialized with different adapters. BF: Cherry-pick of 040a97b which was a squash of https://github.com/rails-api/active_model_serializers/commits/f89ed71058322fe7dd35d5c8b209856f8e03ad14 from pr 1346
|
Does it generates the same cache key for different serializers on the same model ? |
|
@lambda2 if using object.cache_key, then yes, it will. Please open a new issue with some examples of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues work in #1346
Fixes #1344
Cherry-pick of
bf4@040a97b
which was a squash of
https://github.com/rails-api/active_model_serializers/commits/f89ed71058322fe7dd35d5c8b209856f8e03ad14