-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update travis build matrix to include Ruby 2.2.3 for Rails5 #1360
Conversation
My build fails were based on "RAILS_VERSION=5" and in bundle install process getting the following error for ruby versions over 2.2.2:
Will investigate bundle gemfile and dependencies of rails 5 Also want to prevent RAILS_VERSION=5 from being tested below 2.2.2. Will go back to reviewing Build Matrix to exclude rails5 from building below 2.2.3 |
@@ -7,6 +7,7 @@ rvm: | |||
- 2.0.0 | |||
- 2.1 | |||
- 2.2.2 | |||
- 2.2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beauby should we just change 2.2.2 to 2.2.3?
Ok, great! thank you for clarifying that! Once @beauby responds, I can remove the unnecessary rails version, and re submit my pull request |
Just force push to the same branch you made the pr from I expect he'll be okay with replacing 2.2.2 with 2.2.3. There shouldn't be any breaking changes between them, and keeping both just makes the build more expensive B mobile phone
|
@@ -37,6 +37,8 @@ matrix: | |||
env: CAPTURE_STDERR=true | |||
- rvm: jruby-19mode | |||
env: JRUBY_OPTS='--server -Xcompile.invokedynamic=false -Xcli.debug=true --debug' | |||
- rvm: 2.2.3 | |||
env: RAILS_VERSION=master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed. It already tests on master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(That's why there were two builds on master #1360 (comment))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK will remove and force push, thank you!
@KaraAJC Please rebase/squash to one nicely commented commit, give yourself credit in the changelog, force push, and I'll merge it |
hi @beauby Yes, I got a bit stuck determining the best way to squash/rebase and make changes to the changelog. I'm looking for someone to pair with me on it, i should be able to finish it up today. thanks for checking in! |
@KaraAJC if you want to join the ams slack or email me at http://benjaminfleischer.com/pair I'm happy to pair. Some git resources I like linking to: |
Or, I can just merge it and squash it myself, if you'd like |
82b17ae
to
3ab2c2c
Compare
@KaraAJC You are merged, yay! 👯 |
🎆 YAY!! |
contributing to issue #1303
Utilized the following resources for the changes: