Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis build matrix to include Ruby 2.2.3 for Rails5 #1360

Closed
wants to merge 2 commits into from

Conversation

KaraAJC
Copy link
Contributor

@KaraAJC KaraAJC commented Dec 1, 2015

contributing to issue #1303
Utilized the following resources for the changes:

@KaraAJC
Copy link
Contributor Author

KaraAJC commented Dec 2, 2015

My build fails were based on "RAILS_VERSION=5" and in bundle install process getting the following error for ruby versions over 2.2.2:

Could not find gem 'railties (~> 5.0) ruby' in any of the gem sources listed in your Gemfile 
or available on this machine.

Will investigate bundle gemfile and dependencies of rails 5

Also want to prevent RAILS_VERSION=5 from being tested below 2.2.2. Will go back to reviewing Build Matrix to exclude rails5 from building below 2.2.3

@bf4
Copy link
Member

bf4 commented Dec 2, 2015

Hi @KaraAJC Thanks for this.

RAILS_VERSION=master is Rails 5 for now, until a release is tagged, so that's why RAILS_VERSION=5.0 doesn't work; it's just master.

In terms of 2.2.3, I'd ask @beauby if he thinks there's any advantage to testing 2.2.2 and 2.2.3

@@ -7,6 +7,7 @@ rvm:
- 2.0.0
- 2.1
- 2.2.2
- 2.2.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beauby should we just change 2.2.2 to 2.2.3?

@KaraAJC
Copy link
Contributor Author

KaraAJC commented Dec 2, 2015

Ok, great! thank you for clarifying that! Once @beauby responds, I can remove the unnecessary rails version, and re submit my pull request

@bf4
Copy link
Member

bf4 commented Dec 2, 2015

Just force push to the same branch you made the pr from

I expect he'll be okay with replacing 2.2.2 with 2.2.3. There shouldn't be any breaking changes between them, and keeping both just makes the build more expensive

B mobile phone

On Dec 2, 2015, at 6:43 AM, Kara A Carrell [email protected] wrote:

Ok, great! thank you for clarifying that! Once @beauby responds, I can remove the unnecessary rails version, and re submit my pull request


Reply to this email directly or view it on GitHub.

@@ -37,6 +37,8 @@ matrix:
env: CAPTURE_STDERR=true
- rvm: jruby-19mode
env: JRUBY_OPTS='--server -Xcompile.invokedynamic=false -Xcli.debug=true --debug'
- rvm: 2.2.3
env: RAILS_VERSION=master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed. It already tests on master

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(That's why there were two builds on master #1360 (comment))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK will remove and force push, thank you!

@bf4
Copy link
Member

bf4 commented Dec 3, 2015

@KaraAJC Please rebase/squash to one nicely commented commit, give yourself credit in the changelog, force push, and I'll merge it

@beauby
Copy link
Contributor

beauby commented Dec 8, 2015

Hi @KaraAJC, thanks for your PR! Do you need any assistance to achieve the final steps mentioned by @bf4? Other than that, it looks good to me.

@KaraAJC
Copy link
Contributor Author

KaraAJC commented Dec 8, 2015

hi @beauby Yes, I got a bit stuck determining the best way to squash/rebase and make changes to the changelog. I'm looking for someone to pair with me on it, i should be able to finish it up today. thanks for checking in!

@bf4
Copy link
Member

bf4 commented Dec 9, 2015

@KaraAJC if you want to join the ams slack or email me at http://benjaminfleischer.com/pair I'm happy to pair.

Some git resources I like linking to:

@bf4
Copy link
Member

bf4 commented Dec 9, 2015

Or, I can just merge it and squash it myself, if you'd like

@KaraAJC KaraAJC force-pushed the travis-ci-ruby-update branch from 82b17ae to 3ab2c2c Compare December 11, 2015 00:34
@bf4 bf4 closed this in 1301b52 Dec 14, 2015
@bf4
Copy link
Member

bf4 commented Dec 14, 2015

@KaraAJC You are merged, yay! 👯

@KaraAJC
Copy link
Contributor Author

KaraAJC commented Dec 14, 2015

🎆 YAY!!

This was referenced Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants