Handle no serializer source file to digest.

[bf4]

Handle no serializer source file to digest; output warning. Closes #1176

Outputs warning when no serializer source found.

Extracted from #1260

[NullVoxPopuli]

👍 very descriptive error message explains the problem, and says what to do about it! yay
🎉

[NullVoxPopuli]

but why is the freeze on an empty string?

Or is this something special with how the <<-STRING syntax works?

[bf4]

No, just a premature optimization :)

B mobile phone

On Oct 15, 2015, at 6:25 AM, L. Preston Sego III [email protected] wrote:

In lib/active_model/serializer.rb:

@@ -27,6 +27,20 @@ class Serializer
)
/x

• Hashes contents of file for +_cache_digest+

• def self.digest_caller_file(caller_line)

•  serializer_file_path = caller_line[CALLER_FILE]
  

•  serializer_file_contents = IO.read(serializer_file_path)
  

•  Digest::MD5.hexdigest(serializer_file_contents)
  

• rescue TypeError, Errno::ENOENT

•  warn <<-EOF.strip_heredoc
  

•   Cannot digest non-existent file: '#{caller_line}'.
  

•   Please set `::_cache_digest` of the serializer
  

•   if you'd like to cache it.
  

•   EOF
  

•  ''.freeze
  

  but why is the freeze on an empty string?

Or is this something special with how the <<-STRING syntax works?

—
Reply to this email directly or view it on GitHub.

[beauby]

Have we fixed the case where the error is spit because the file name contains a whitespace?

[bf4]

Don't think so

B mobile phone

On Oct 21, 2015, at 3:53 PM, Lucas Hosseini [email protected] wrote:

In lib/active_model/serializer.rb:

@@ -27,6 +27,20 @@ class Serializer
)
/x

• Hashes contents of file for +_cache_digest+

• def self.digest_caller_file(caller_line)

•  serializer_file_path = caller_line[CALLER_FILE]
  

•  serializer_file_contents = IO.read(serializer_file_path)
  

•  Digest::MD5.hexdigest(serializer_file_contents)
  

• rescue TypeError, Errno::ENOENT

•  warn <<-EOF.strip_heredoc
  

•   Cannot digest non-existent file: '#{caller_line}'.
  

•   Please set `::_cache_digest` of the serializer
  

•   if you'd like to cache it.
  

•   EOF
  

•  ''.freeze
  

  Have we fixed the case where the error is spit because the file name contains a whitespace?

—
Reply to this email directly or view it on GitHub.

[beauby]

What does this PR fix actually? Was the problem not all along that we don't handle whitespace in filenames?

[bf4]

When there's no source file. More info in description and tests

B mobile phone

On Oct 21, 2015, at 6:06 PM, Lucas Hosseini [email protected] wrote:

What does this PR fix actually? Was the problem not all along that we don't handle whitespace in filenames?

[beauby]

Yeah but what I meant was that the bug actually arose in the case the source file was deemed non-existent because the regex would not allow for whitespace.

[bf4]

Ok

B mobile phone

On Oct 21, 2015, at 6:20 PM, Lucas Hosseini [email protected] wrote:

In lib/active_model/serializer.rb:

@@ -27,6 +27,20 @@ class Serializer
)
/x

• Hashes contents of file for +_cache_digest+

• def self.digest_caller_file(caller_line)

•  serializer_file_path = caller_line[CALLER_FILE]
  

•  serializer_file_contents = IO.read(serializer_file_path)
  

•  Digest::MD5.hexdigest(serializer_file_contents)
  

• rescue TypeError, Errno::ENOENT

•  warn <<-EOF.strip_heredoc
  

•   Cannot digest non-existent file: '#{caller_line}'.
  

•   Please set `::_cache_digest` of the serializer
  

•   if you'd like to cache it.
  

•   EOF
  

•  ''.freeze
  

  Yeah but what I meant was that the bug actually arose in the case the source file was deemed non-existent because the regex would not allow for whitespace.

—
Reply to this email directly or view it on GitHub.

[bf4]

@NullVoxPopuli wanna label LGTM?

[NullVoxPopuli]

LGTM. Will merge when Travis passes