Extract attributes filtering from serializer into adapter. #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beauby
force-pushed
the
move-root-to-adapter
branch
from
c69fa49 to
19c2558
Compare
beauby
force-pushed
the
move-root-to-adapter
branch
3 times, most recently
from
8179beb to
387d548
Compare
beauby
force-pushed
the
move-root-to-adapter
branch
from
387d548 to
658810e
Compare
| @@ -57,7 +57,10 @@ def include_meta(json) | |||
|
|
|||
| def resource_object_for(options) | |||
| cache_check(serializer) do | |||
| serializer.attributes(options) | |||
| attributes = serializer.attributes | |||
| attributes.slice!(*options[:fields]) if options[:fields] | |||
There was a problem hiding this comment.
why did this need to be added?
There was a problem hiding this comment.
This is actually the main change of this PR: instead of being handled at serializer level, this is now handled at adapter level which allows for different format per adapter.
|
lgtm 👍 |
NullVoxPopuli
added a commit
that referenced
this pull request
Oct 5, 2015
Extract attributes filtering from serializer into adapter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering attributes is an adapter concern. Plus, this PR simplifies the
Fieldsetutility class by constraining it to the JSON API use case.